Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoDJ : Track marked as played when loaded #10454

Closed
mixxxbot opened this issue Aug 23, 2022 · 4 comments
Closed

AutoDJ : Track marked as played when loaded #10454

mixxxbot opened this issue Aug 23, 2022 · 4 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: eleduc
Date: 2021-06-29T15:44:19Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1933991
Tags: autodj, library, regression


When using AutoDJ, the next track is sometimes marked as played as soon as it is loaded on the second deck. This happens quite randomly and more often with 5 seconds or less transition time. The chosen AutoDJ mode does not seem to have an effect.

This is causing the timestamps and the order of tracks played wrong in the history log.

In this 1st capture, you can see an example for an album loaded in order in AutoDJ:
https://imgur.com/xPa8JHa

In this 2nd capture, you can see the result with wrong order and timestamps:
https://imgur.com/VX3Hy4u

As I said, the result is random and not always the same with the same album/playlist. The previous version 2.2.4 was not behaving like this. I noticed this bug around last December in version 2.3 and 2.4 that I am compiling myself on a regular basis since then in Ubuntu GNU/Linux. I just tested the official stable version 2.3 and this bug is unfortunately there.

I test on 2 high-end systems with the same result under Ubuntu GNU/Linux 21.04 on AMD and Intel cpus. Let me know if you need more info but I do not have the feeling it is linked with my hardware. This bug is quite easy to reproduce I believe.

I would be happy to do some testing and I can compile a dev version to test if need be. I looked at the code but I have zero experience with MIXXX messaging architecture between the components.

Thank you very much to all the developers, MIXXX is the best! :-)

Eric

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-06-29T21:10:55Z


Ah, there is an issue when the track changes, before the regular timer has expired to update the playing track. I will provide a fix.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-06-29T23:07:19Z


A possible fix is here:
#4041

@mixxxbot
Copy link
Collaborator Author

Commented by: eleduc
Date: 2021-06-30T18:02:11Z


I can confirm the fix is working really well, the history log is now accurate.

Thank you very much for the quick response!

Too bad I did not report this before the 2.3.0 release...

Thanks again and keep up the good work!

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.1 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant