From 4def2d52e7cebf927e3de7748f724c761ca557a6 Mon Sep 17 00:00:00 2001
From: Owen Williams <owilliams@mixxx.org>
Date: Sat, 12 Feb 2022 20:50:05 -0500
Subject: [PATCH] remove const qualifiers from value parameters

---
 src/effects/backends/effectprocessor.h   | 8 ++++----
 src/engine/effects/engineeffect.cpp      | 4 ++--
 src/engine/effects/engineeffect.h        | 4 ++--
 src/engine/effects/engineeffectchain.cpp | 4 ++--
 src/engine/effects/engineeffectchain.h   | 4 ++--
 5 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/effects/backends/effectprocessor.h b/src/effects/backends/effectprocessor.h
index a5b7d157c916..837da2b91043 100644
--- a/src/effects/backends/effectprocessor.h
+++ b/src/effects/backends/effectprocessor.h
@@ -74,10 +74,10 @@ class EffectProcessor {
     virtual void loadEngineEffectParameters(
             const QMap<QString, EngineEffectParameterPointer>& parameters) = 0;
     virtual EffectState* createState(const mixxx::EngineParameters& engineParameters) = 0;
-    virtual void deleteStatesForInputChannel(const ChannelHandle inputChannel) = 0;
+    virtual void deleteStatesForInputChannel(ChannelHandle inputChannel) = 0;
 
     // Called from the audio thread
-    virtual bool loadStatesForInputChannel(const ChannelHandle inputChannel,
+    virtual bool loadStatesForInputChannel(ChannelHandle inputChannel,
             const EffectStatesMap* pStatesMap) = 0;
 
     /// Called from the audio thread
@@ -202,7 +202,7 @@ class EffectProcessorImpl : public EffectProcessor {
         return createSpecificState(engineParameters);
     };
 
-    bool loadStatesForInputChannel(const ChannelHandle inputChannel,
+    bool loadStatesForInputChannel(ChannelHandle inputChannel,
             const EffectStatesMap* pStatesMap) final {
         if (kEffectDebugOutput) {
             qDebug() << "EffectProcessorImpl::loadStatesForInputChannel" << this
@@ -256,7 +256,7 @@ class EffectProcessorImpl : public EffectProcessor {
     };
 
     /// Called from main thread for garbage collection after an input channel is disabled
-    void deleteStatesForInputChannel(const ChannelHandle inputChannel) final {
+    void deleteStatesForInputChannel(ChannelHandle inputChannel) final {
         if (kEffectDebugOutput) {
             qDebug() << "EffectProcessorImpl::deleteStatesForInputChannel"
                      << this << inputChannel;
diff --git a/src/engine/effects/engineeffect.cpp b/src/engine/effects/engineeffect.cpp
index 8b63b2bd2f4f..20e9b30e3709 100644
--- a/src/engine/effects/engineeffect.cpp
+++ b/src/engine/effects/engineeffect.cpp
@@ -53,7 +53,7 @@ EffectState* EngineEffect::createState(const mixxx::EngineParameters& enginePara
     return m_pProcessor->createState(engineParameters);
 }
 
-void EngineEffect::loadStatesForInputChannel(const ChannelHandle inputChannel,
+void EngineEffect::loadStatesForInputChannel(ChannelHandle inputChannel,
         EffectStatesMap* pStatesMap) {
     if (kEffectDebugOutput) {
         qDebug() << "EngineEffect::loadStatesForInputChannel" << this
@@ -62,7 +62,7 @@ void EngineEffect::loadStatesForInputChannel(const ChannelHandle inputChannel,
     m_pProcessor->loadStatesForInputChannel(inputChannel, pStatesMap);
 }
 
-void EngineEffect::deleteStatesForInputChannel(const ChannelHandle inputChannel) {
+void EngineEffect::deleteStatesForInputChannel(ChannelHandle inputChannel) {
     m_pProcessor->deleteStatesForInputChannel(inputChannel);
 }
 
diff --git a/src/engine/effects/engineeffect.h b/src/engine/effects/engineeffect.h
index aa4b5ba78a2d..ea83a6fbc158 100644
--- a/src/engine/effects/engineeffect.h
+++ b/src/engine/effects/engineeffect.h
@@ -35,10 +35,10 @@ class EngineEffect final : public EffectsRequestHandler {
     EffectState* createState(const mixxx::EngineParameters& engineParameters);
 
     /// Called in audio thread to load EffectStates received from the main thread
-    void loadStatesForInputChannel(const ChannelHandle inputChannel,
+    void loadStatesForInputChannel(ChannelHandle inputChannel,
             EffectStatesMap* pStatesMap);
     /// Called from the main thread for garbage collection after an input channel is disabled
-    void deleteStatesForInputChannel(const ChannelHandle inputChannel);
+    void deleteStatesForInputChannel(ChannelHandle inputChannel);
 
     /// Called in audio thread
     bool processEffectsRequest(
diff --git a/src/engine/effects/engineeffectchain.cpp b/src/engine/effects/engineeffectchain.cpp
index 73adccc4f2f5..c3101ecb5ab3 100644
--- a/src/engine/effects/engineeffectchain.cpp
+++ b/src/engine/effects/engineeffectchain.cpp
@@ -146,7 +146,7 @@ bool EngineEffectChain::processEffectsRequest(EffectsRequest& message,
     return true;
 }
 
-bool EngineEffectChain::enableForInputChannel(const ChannelHandle inputHandle,
+bool EngineEffectChain::enableForInputChannel(ChannelHandle inputHandle,
         EffectStatesMapArray* statesForEffectsInChain) {
     if (kEffectDebugOutput) {
         qDebug() << "EngineEffectChain::enableForInputChannel" << this << inputHandle;
@@ -180,7 +180,7 @@ bool EngineEffectChain::enableForInputChannel(const ChannelHandle inputHandle,
     return true;
 }
 
-bool EngineEffectChain::disableForInputChannel(const ChannelHandle inputHandle) {
+bool EngineEffectChain::disableForInputChannel(ChannelHandle inputHandle) {
     auto& outputMap = m_chainStatusForChannelMatrix[inputHandle];
     for (auto&& outputChannelStatus : outputMap) {
         if (outputChannelStatus.enableState != EffectEnableState::Disabled) {
diff --git a/src/engine/effects/engineeffectchain.h b/src/engine/effects/engineeffectchain.h
index ade6e74d43f1..9bb5aa6ac355 100644
--- a/src/engine/effects/engineeffectchain.h
+++ b/src/engine/effects/engineeffectchain.h
@@ -64,9 +64,9 @@ class EngineEffectChain final : public EffectsRequestHandler {
     bool updateParameters(const EffectsRequest& message);
     bool addEffect(EngineEffect* pEffect, int iIndex);
     bool removeEffect(EngineEffect* pEffect, int iIndex);
-    bool enableForInputChannel(const ChannelHandle inputHandle,
+    bool enableForInputChannel(ChannelHandle inputHandle,
             EffectStatesMapArray* statesForEffectsInChain);
-    bool disableForInputChannel(const ChannelHandle inputHandle);
+    bool disableForInputChannel(ChannelHandle inputHandle);
 
     // Gets or creates a ChannelStatus entry in m_channelStatus for the provided
     // handle.