Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new React Native new architecture #209

Closed
bhaskarathma opened this issue Aug 18, 2023 · 16 comments
Closed

Support new React Native new architecture #209

bhaskarathma opened this issue Aug 18, 2023 · 16 comments

Comments

@bhaskarathma
Copy link

With Fabric/Turbomodules now being available for please add add support for it

See https://reactnative.dev/docs/new-architecture-library-intro

https://reactnative.dev/blog/2022/06/16/resources-migrating-your-react-native-library-to-the-new-architecture

@ChaimMark
Copy link

Any update?

@AdamGerthel
Copy link

I'm curious about this as well. Mixpanel and RN AppsFlyer are my current blockers for moving to the new arch.

@Titozzz
Copy link

Titozzz commented Jul 11, 2024

Hey there! @zihejia 👋🏻
Would it be possible to get some update on that topic?

  • Is it being worked on internally?
  • Are you waiting for external contributors?

The new arch is here, and close to being enabled by default and if Mixpanel becomes a blocker to update it might push away users.

@bfar97
Copy link

bfar97 commented Jul 11, 2024

+1 on Mixpanel starting to be a major blocker for us, not allowing is to move to the new arch.

@brentvatne
Copy link

@zihejia @jaredmixpanel - hi there! I work on expo and closely with the react-native team at meta on assisting in the roll out of the new architecture for react-native. we're moving towards enabling the new architecture by default in react-native later this year, and so we're proactively reaching out for maintainers of popular libraries to get the ball rolling in some third party libraries (more info).

here's a guide with more info on how you can proceed: "Enable the New Architecture for Libraries"

if you need any assistance, let us know! just a heads up that i've heard that at least one customer is considering moving away from mixpanel due to this blocking their migration to the new architecture, so it may be worth addressing sooner than later.

@Qdafengzi
Copy link

open new architecture cannot open , please update

error page

@evanbiskey
Copy link

evanbiskey commented Aug 14, 2024

For those having trouble with this, we found a workaround using JS-only mode:

Follow instructions for Expo/Web set up: https://docs.mixpanel.com/docs/tracking-methods/sdks/react-native#expo-and-web-support

Then disable auto-linking the dependency with the react-native.config.js file:

module.exports = {
  dependencies: {
    'mixpanel-react-native': {
      platforms: {
        android: null,
        ios: null,
      },
    },
  },
};

This appears to keep the library running only on the JS layer without the need for the native side that is causing the app to crash. So far, this has given us the functionality that we need, but YMMV.

@jaredmixpanel
Copy link
Collaborator

Update here: The folks at Meta have just merged this React Native PR to add support for com.facebook.react.bridge.Dynamic to the New Architecture: facebook/react-native#45944

Once that is released this issue should be resolved.

@cortinico
Copy link

We're planning to ship this hotfix to 0.75.x and 0.74.x

You can follow the status of those 2 picks here:

@PierreCapo
Copy link

Hello @jaredmixpanel is the support of com.facebook.react.bridge.Dynamic starting from 0.75 is enough or are you waiting to also get it merged into 0.74?

@jaredmixpanel
Copy link
Collaborator

@PierreCapo No changes are required on the Mixpanel side, this library should work with 0.75 now. I'll just keep this issue open until the 0.74 support is merged.

@PierreCapo
Copy link

Oh awesome, thanks Jared 🔥

@jaredmixpanel
Copy link
Collaborator

Closing this issue as reactwg/react-native-releases#440 is now also closed/merged

@Serdnad
Copy link

Serdnad commented Oct 25, 2024

reactnative.directory is still showing this library as not supporting the New Architecture, is that just incorrect?

If it is, might be worth getting corrected, given that directory is what the official expo-doctor uses to report library support.

@jaredmixpanel
Copy link
Collaborator

@Serdnad Thanks for the heads up, I've opened a PR here: react-native-community/directory#1336

@niteshbalusu11
Copy link

niteshbalusu11 commented Jan 16, 2025

@jaredmixpanel I know this issue is closed. I am still seeing this error:

 "mixpanel-react-native": "3.0.8",
  "react-native": "0.74.5",
   "expo": "^51.0.39",

Update: updating to react-native 0.74.6 fixed the issue.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests