-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new React Native new architecture #209
Comments
Any update? |
I'm curious about this as well. Mixpanel and RN AppsFlyer are my current blockers for moving to the new arch. |
Hey there! @zihejia 👋🏻
The new arch is here, and close to being enabled by default and if Mixpanel becomes a blocker to update it might push away users. |
+1 on Mixpanel starting to be a major blocker for us, not allowing is to move to the new arch. |
@zihejia @jaredmixpanel - hi there! I work on expo and closely with the react-native team at meta on assisting in the roll out of the new architecture for react-native. we're moving towards enabling the new architecture by default in react-native later this year, and so we're proactively reaching out for maintainers of popular libraries to get the ball rolling in some third party libraries (more info). here's a guide with more info on how you can proceed: "Enable the New Architecture for Libraries" if you need any assistance, let us know! just a heads up that i've heard that at least one customer is considering moving away from mixpanel due to this blocking their migration to the new architecture, so it may be worth addressing sooner than later. |
For those having trouble with this, we found a workaround using JS-only mode: Follow instructions for Expo/Web set up: https://docs.mixpanel.com/docs/tracking-methods/sdks/react-native#expo-and-web-support Then disable auto-linking the dependency with the
This appears to keep the library running only on the JS layer without the need for the native side that is causing the app to crash. So far, this has given us the functionality that we need, but YMMV. |
Update here: The folks at Meta have just merged this React Native PR to add support for Once that is released this issue should be resolved. |
We're planning to ship this hotfix to 0.75.x and 0.74.x You can follow the status of those 2 picks here: |
Hello @jaredmixpanel is the support of |
@PierreCapo No changes are required on the Mixpanel side, this library should work with 0.75 now. I'll just keep this issue open until the 0.74 support is merged. |
Oh awesome, thanks Jared 🔥 |
Closing this issue as reactwg/react-native-releases#440 is now also closed/merged |
reactnative.directory is still showing this library as not supporting the New Architecture, is that just incorrect? If it is, might be worth getting corrected, given that directory is what the official expo-doctor uses to report library support. |
@Serdnad Thanks for the heads up, I've opened a PR here: react-native-community/directory#1336 |
@jaredmixpanel I know this issue is closed. I am still seeing this error:
Update: updating to react-native 0.74.6 fixed the issue. |
With Fabric/Turbomodules now being available for please add add support for it
See https://reactnative.dev/docs/new-architecture-library-intro
https://reactnative.dev/blog/2022/06/16/resources-migrating-your-react-native-library-to-the-new-architecture
The text was updated successfully, but these errors were encountered: