Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable HIBP URL #25

Open
mfal opened this issue Aug 9, 2024 · 1 comment
Open

Configurable HIBP URL #25

mfal opened this issue Aug 9, 2024 · 1 comment
Assignees

Comments

@mfal
Copy link

mfal commented Aug 9, 2024

The HIBP URL should be configurable, due use own hosted/proxied HIBP checks, because submitting IPs to HIBP must be agreed by the user.

https://github.com/mittwald/password-tools-js/blob/main/src/rule/hibp/declaration.ts#L3

@mfal mfal assigned ins0 Aug 9, 2024
@ins0
Copy link
Member

ins0 commented Aug 9, 2024

I think it would enough to add a "Custom Callback Policy" so you're free to choose what implementation you would like to offer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants