Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to tokio 0.3 #396

Closed
djc opened this issue Oct 17, 2020 · 8 comments · Fixed by #405
Closed

Upgrade to tokio 0.3 #396

djc opened this issue Oct 17, 2020 · 8 comments · Fixed by #405

Comments

@djc
Copy link
Contributor

djc commented Oct 17, 2020

Would be nice to have.

@vipera
Copy link

vipera commented Nov 16, 2020

I just took a quick look, and it looks like Marwes/combine#302 would have to be addressed first, as that's a Tokio 0.2 dependency.

@djc
Copy link
Contributor Author

djc commented Nov 16, 2020

Yes, I came to the same conclusion when I was looking at this.

Marwes pushed a commit to Marwes/redis-rs that referenced this issue Nov 17, 2020
Marwes pushed a commit to Marwes/redis-rs that referenced this issue Nov 18, 2020
Marwes pushed a commit to Marwes/redis-rs that referenced this issue Nov 18, 2020
Marwes pushed a commit to Marwes/redis-rs that referenced this issue Nov 18, 2020
@Austaras
Copy link

But combine has a feature flag for tokio 0.3?

@djc
Copy link
Contributor Author

djc commented Nov 19, 2020

(Looks like this is being fixed over in #405.)

@RAnders00
Copy link
Contributor

RAnders00 commented Nov 24, 2020

combine now has tokio 0.3 support in v4.4.0.

@nazar-pc
Copy link

nazar-pc commented Dec 7, 2020

Well, now #378 didn't arrive in 0.17.x, but 0.18.x is incompatible with Tokio 0.2 that Actix uses 😞

@Marwes
Copy link
Collaborator

Marwes commented Dec 7, 2020

You can use https://github.com/LucioFranco/tokio-compat-02/ to use tokio 0.2 and 0.3 simultaneously @nazar-pc

@nazar-pc
Copy link

nazar-pc commented Dec 7, 2020

Only works the other way around unfortunately. There is an issue in Actix about upgrading to 0.3, will use a git commit that includes above fix for the time being.

barshaul pushed a commit to barshaul/redis-rs that referenced this issue Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants