Fix compilability with /Zc:preprocessor #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in array_macro.h assumed that definition of _MSC_VER macro implies that the traditional MSVC preprocessor is used. This is not always the case. Since VS 2017 15.8 MSVC offers a new preprocessor which is standard conforming. The new mode is available with /Zc:preprocessor compiler option. Previously it was available with /experimental:preprocessor. Availability of the new mode means that it is no longer enough to check only for the definition of _MSC_VER. One has to check the macro _MSVC_TRADITIONAL too. This check is necessary since the macro that definitions of ENOKI_MAP_EXPR_NEXT_1 and ENOKI_MAP_STMT_NEXT_1 are otherwise incorrect and they don't work with standard conforming preprocessor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in array_macro.h assumed that definition of
_MSC_VERmacro implies that the traditional MSVC preprocessor is used.This is not always the case. Since VS 2017 15.8 MSVC offers a new preprocessor which is standard conforming. The new mode is available with
/Zc:preprocessorcompiler option. Previously it was available with/experimental:preprocessor.Availability of the new mode means that it is no longer enough to check only for the definition of
_MSC_VER. One has to check the macro_MSVC_TRADITIONALtoo.This check is necessary since the macro that definitions of
ENOKI_MAP_EXPR_NEXT_1andENOKI_MAP_STMT_NEXT_1are otherwise incorrect and they don't work with standard conforming preprocessor.