-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VIRTS-4690] Add Architecture Header to Sandcat #435
Conversation
Code looked good but I could not test out ARM on my Mac. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original PR also updated update-agents.sh
and the list of precompiled binaries on the docs page - can you update those as well?
For the docs page, I would prefer adding architecture
to the list of parameters and explaining it there instead of at the top of the Options
section.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Allows users to supply an architecture header to sandcat. This will allow Darwin ARM64 users to successfully compile sandcat without emulation.
Additionally, an
architecture
key has been added to the sandcat ability file. The frontend can later be modified to use this, so that users can select platform and architecture on the agents page. Currently, all sandcat commands are being listed, but they have been labeled as (ARM64) or (AMD64).Includes modifications to #423.
Type of change
How Has This Been Tested?
Ran all of new agent commands for ARM64, and ran a few abilities with each. Agents compiled successfully and were able to transmit data successfully as well. When running
file splunkd
, the output verified that the agent was compiled for ARM64.Checklist: