-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Broken release build for Hipcheck.
Turns out Cargo doesn't like when materials required to build a crate are outside of the crate manifest directory. In this case, I'm talking about the protobuf definition used for the Hipcheck plugin gRPC service. There's a Cargo issue open about it, but the gist of it is that they don't really want people doing what we were trying to do, having materials in an outer directory. There may be better solutions, but moving the files is the fastest one for now. Here's the issue: rust-lang/cargo#3946 Signed-off-by: Andrew Lilley Brinker <[email protected]>
- Loading branch information
1 parent
34e04af
commit 353dbae
Showing
5 changed files
with
12 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,12 @@ | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
fn main() -> anyhow::Result<()> { | ||
tonic_build::compile_protos("../proto/hipcheck/v1/hipcheck.proto")?; | ||
use anyhow::Result; | ||
use pathbuf::pathbuf; | ||
use tonic_build::compile_protos; | ||
|
||
fn main() -> Result<()> { | ||
let root = env!("CARGO_MANIFEST_DIR"); | ||
let path = pathbuf![root, "proto", "hipcheck", "v1", "hipcheck.proto"]; | ||
compile_protos(path)?; | ||
Ok(()) | ||
} |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
fn main() -> anyhow::Result<()> { | ||
tonic_build::compile_protos("../../proto/hipcheck/v1/hipcheck.proto")?; | ||
tonic_build::compile_protos("../../hipcheck/proto/hipcheck/v1/hipcheck.proto")?; | ||
Ok(()) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
fn main() -> anyhow::Result<()> { | ||
tonic_build::compile_protos("../../proto/hipcheck/v1/hipcheck.proto")?; | ||
tonic_build::compile_protos("../../hipcheck/proto/hipcheck/v1/hipcheck.proto")?; | ||
Ok(()) | ||
} |