Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure style for techniques with comments #53

Closed
johnwunder opened this issue Jul 11, 2018 · 2 comments
Closed

Configure style for techniques with comments #53

johnwunder opened this issue Jul 11, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request seeking feedback Seeking feedback from the community on this issue

Comments

@johnwunder
Copy link
Collaborator

This is more a speculative idea than an actual request, but what do people think about the idea of allowing user configuration (or maybe server owner configuration beyond just editing the CSS?) of the "comment" style?

I have some autogenerated layers that provide comments for every technique in the matrix. When that happens, it makes it look very busy. I'd love to keep the comments, but just not show the yellow underline. I know I can fix this by altering the CSS, just wondering if others had run into the same thing.

@johnwunder johnwunder added the enhancement New feature or request label Jul 11, 2018
@isaisabel
Copy link
Contributor

I like this idea. All the rest of the colors used in the Navigator (tactic row header, score gradient, manually assigned colors) are completely customizable so it'd be good to allow the user to change the style (color, visibility) in case it clashes.

For now the scss here is where the comment style is defined.

@jburns12 jburns12 added the seeking feedback Seeking feedback from the community on this issue label Jul 11, 2018
@isaisabel isaisabel self-assigned this Nov 26, 2018
@isaisabel
Copy link
Contributor

The color of the underline can now be specified using the comment_color field in the config file. The comment underline can be removed through the value "transparent". Non-underline styles are not currently supported as they could conflict with the rest of the Matrix UI. This feature was implemented in feature/user-defined-metadata and merged into develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request seeking feedback Seeking feedback from the community on this issue
Projects
None yet
Development

No branches or pull requests

3 participants