Add row header to order history table #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinpreston
approved these changes
May 26, 2023
There was a problem hiding this comment.
Looks good and tested correctly. When using VoiceOver, if the focus is on a single cell such as the far right column "view", and you then move the focus to the "view" column for a row above or below, the screen reader will pronounce the row header (order title) before reading the content of the focused cell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Flight checklist
What are the relevant tickets?
Fix https://github.com/mitodl/hq/issues/718
What's this PR do?
Add row header to order history table
How should this be manually tested?
Nothing should break.
Use a screen reader to make sure that it reads the row index.