Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open edX: Wrong link and alt text in the MITx Online footer image of edX LMS #200

Closed
2 tasks
briangrossman opened this issue Sep 15, 2021 · 5 comments
Closed
2 tasks
Assignees

Comments

@briangrossman
Copy link

The MITx Online logo image in the footer has the wrong link and alt text (example page)

Please:

  • Change the alt text to MITx Online
  • Change the href link to https://mitxonline.mit.edu/ or https://rc.mitxonline.mit.edu/ depending on platform

Current HTML

<a class="d-block" href="https://open.edx.org" aria-label="edX Home">
     <img src="https://raw.githubusercontent.com/mitodl/mitxonline-theme/main/lms/static/images/logo.png" alt="Powered by Open edX" style="max-height: 45px;">
</a>

Image
Screen Shot 2021-09-15 at 2 05 55 PM

@pdpinch
Copy link
Member

pdpinch commented Sep 16, 2021

I just realized, this isn't in the theme. It's part of the MFE.

Here's an example URL, which is served through the MFE: https://courses-qa.mitxonline.mit.edu/learn/course/course-v1:MITx+14.100x+3T2021/block-v1:MITx+14.100x+3T2021+type@sequential+block@b7cd91c5366f4fb1b577d660a151205f/block-v1:MITx+14.100x+3T2021+type@vertical+block@15501c3d139148cb98b70fdbb43051d8

I'd hope this is a configuration that can be overridden, but I'm not sure.

@pdpinch pdpinch transferred this issue from mitodl/mitxonline-theme Sep 16, 2021
@pdpinch pdpinch changed the title Wrong link and alt text in the MITx Online footer image of edX LMS open edX: Wrong link and alt text in the MITx Online footer image of edX LMS Sep 16, 2021
@Wassaf-Shahzad Wassaf-Shahzad self-assigned this Sep 20, 2021
@Wassaf-Shahzad
Copy link
Contributor

Wassaf-Shahzad commented Sep 21, 2021

@pdpinch, I had a detailed conversation with @arslanashraf7 regarding this issue yesterday and wanted some of your input on a few matters.
We isolated the issue and its seems that the redirect link is hardcoded in edx/frontend-component-footer component and the alt tag seems to be coming from a predefined set from Footer.messages.js in edx/frontend-component-footer.

We could use the MARKETING_SITE_BASE_URL for the redirect link and SITE_NAME for alt tag or define new Environment variables and your input on this would be required.

Also since the issue lies in edx/frontend-component-footer, we might need to fork it in the mitodl organisation.

@briangrossman
Copy link
Author

@Wassaf-Shahzad
Note that this issue has been replaced by #223, which is a more universal solution for the footer

@Wassaf-Shahzad
Copy link
Contributor

@Wassaf-Shahzad Note that this issue has been replaced by #223, which is a more universal solution for the footer

@briangrossman Should we close this issue ?

@briangrossman
Copy link
Author

Closing since will be addressed by #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants