Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parallel jobs: each job adds its annotations without deleting others added by other jobs #74

Open
vt89 opened this issue Mar 8, 2024 · 1 comment

Comments

@vt89
Copy link

vt89 commented Mar 8, 2024

Suppose a Pull Request has an Apex Class with a single PMD violation and an LWC with a single violation.

We want to have a GitHub Action with two parallel jobs (instead of a single one): one for PMD checks (using engine: pmd) and another for the ESLintLWC violations (using engine: eslint-lwc).

I have noticed that either the PMD or the ESLintLWC result is added as annotation, but not both.
I suppose it happens because both jobs execute the SFDX Scanner with all the changes files in the Pull Request and since we have specified the engine (either pmd or eslint-lwc) the last ending job deletes the result of the other jobs and only its result is shown (either for PMD or ESLintLWC).

It would be nice if each (parallel) job does not delete the result of other executed jobs. Another solution could be to invoke the SFDX Scanner passing only the proper files based on the specified engine: it means if the engine is pmd, invoke the SFDX Scanner passing only the right files (e.g. Apex Class, Visualforce Page) even if the Pull Request contains also other files.

@vt89 vt89 changed the title Add support for parallel jobs: each job adds its annotations/comment without deleting others added by other jobs Add support for parallel jobs: each job adds its annotations without deleting others added by other jobs Mar 8, 2024
@vt89
Copy link
Author

vt89 commented Mar 8, 2024

I just noticed that this behaviour happens when the report-mode is check-runs.
If we use report-mode: comments then all the comments from all the parallel jobs are added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant