Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin chosen improvements #743

Merged
merged 4 commits into from
Nov 25, 2018

Conversation

mokaddem
Copy link
Contributor

@mokaddem mokaddem commented Nov 8, 2018

Merge request checklist

  • I read the guidelines for contributing
  • I created my branch from dev and I am issuing the PR to dev
  • I didn't pushed the dist directory
  • Unit tests are OK (no unit tests)
  • If it's a new feature, I added the necessary unit tests (no unit tests)
  • If it's a new language, I filled the __locale and __author fields (not applicable)

Hello,
First of all thanks for this awesome project!
I'm currently using it with the chosen plugin but I had to modify a bit the source code of the plugins/chosen-selectpicker/plugin.js script so that it better fits my needs.

Please, if you have any comments or suggestions about the code, feel free to share them.

Changes

  • Avoid creating a useless glitchy chosen widget when the operator only contains one option
  • Add a chosen widget on the value container (if eligible)

src/plugins/chosen-selectpicker/plugin.js Outdated Show resolved Hide resolved
src/plugins/chosen-selectpicker/plugin.js Outdated Show resolved Hide resolved
@mistic100 mistic100 merged commit 507e416 into mistic100:dev Nov 25, 2018
bagulho pushed a commit to bagulho/jQuery-QueryBuilder that referenced this pull request Jun 24, 2020
* dev:
  possibility to define a dynamic field
  Swedish translations (mistic100#865)
  Hungarian translation (mistic100#862)
  Remove travis
  Updated italian translation (mistic100#837)
  Slovak translation (mistic100#830)
  Add Github CI
  Russian translation typos (mistic100#820)
  Added missing Russian strings in main translation (Translation by Hubbitus)
  Updated Russian translation (Translation by Hubbitus)
  Added Lithuanian translation (mistic100#766)
  Support different placeholders for each input when nb_inputs > 1 (mistic100#764)
  Added swahili translation (mistic100#754)
  feat: add source map for easier debugging (mistic100#749)
  chg: [plugin:chosen] avoid creating useless chosen widget (mistic100#743)
  Make some methods visible in the doc (mistic100#696 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants