Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Costs No Longer Work #30

Closed
VoltCruelerz opened this issue Jun 3, 2022 · 5 comments
Closed

Reference Costs No Longer Work #30

VoltCruelerz opened this issue Jun 3, 2022 · 5 comments
Labels
Enhancement New feature or request

Comments

@VoltCruelerz
Copy link

VoltCruelerz commented Jun 3, 2022

With the most recent update, reference costs like the following no longer work. They're just treated as 0.

image

(I was using this as a workaround for #26.)

@misthero
Copy link
Owner

misthero commented Jun 3, 2022

hi, the cost calculation has not changed, where that owlmarble-magic flag comes from?
another module maybe?

@VoltCruelerz
Copy link
Author

VoltCruelerz commented Jun 3, 2022

I added those flags with a one-off script I wrote a couple months back. I can validate that the flag is still set though. It's even still accessible through more conventional means, like plugging it into the damage field of a weapon:

image

In testing, I can see that I can still set spell point costs to other references like @abilities.cha.value.

I checked another flag (one I didn't create) to see if it was accessible to the spell costs, and found it isn't either. In Data Inspector, I can see that flags are part of Roll Data, but not Source or Derived. I'm not familiar enough with scripting for Foundry to know if that's significant here.

image

If things didn't change on your end, did the 5e system itself change in some way, do you know?

@misthero
Copy link
Owner

misthero commented Jun 3, 2022

yes, 5e system introduced some breaking changes in version 1.6+

this could be another one

@VoltCruelerz
Copy link
Author

VoltCruelerz commented Jun 3, 2022

Well, I installed an older version of your mod and the problem persisted, so I guess this must have been introduced in 5e 1.6.2, because it was fine for 1.6.1.

Closing.

EDIT: I've also now confirmed that it was a 5e system issue. 1.6.1 works. 1.6.2 doesn't.

@misthero
Copy link
Owner

misthero commented Jun 3, 2022

I've talked with dnd5e developers about this, the say that flags have never been available in the roll data this module was passing for formula evaluation.
Probably you had some other module messing around, anyway I don't see why flags shoudnt be available so I made a modification to the funcion that evaluates the formula including the flags object.

Now your formula should work. (v 1.3.7)

@misthero misthero added the Enhancement New feature or request label Jun 3, 2022
@misthero misthero reopened this Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants