Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: ユーザーコンテンツのインポート操作の実行可否をロールで制御できるように #14583

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

かいてあるとおり

Why

Fix #14581

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 21.62162% with 145 lines in your changes missing coverage. Please review.

Project coverage is 41.48%. Comparing base (8d23122) to head (99db578).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/admin/roles.editor.vue 0.00% 100 Missing ⚠️
packages/frontend/src/pages/admin/roles.vue 0.00% 40 Missing ⚠️
...ages/frontend/src/pages/settings/import-export.vue 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14583      +/-   ##
===========================================
+ Coverage    39.77%   41.48%   +1.71%     
===========================================
  Files         1539     1543       +4     
  Lines       191686   197603    +5917     
  Branches      2482     2607     +125     
===========================================
+ Hits         76241    81984    +5743     
- Misses      114883   115057     +174     
  Partials       562      562              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 19, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -80932,6 +80932,21 @@
           },
           "avatarDecorationLimit": {
             "type": "integer"
+          },
+          "canImportAntennas": {
+            "type": "boolean"
+          },
+          "canImportBlocking": {
+            "type": "boolean"
+          },
+          "canImportFollowing": {
+            "type": "boolean"
+          },
+          "canImportMuting": {
+            "type": "boolean"
+          },
+          "canImportUserLists": {
+            "type": "boolean"
           }
         },
         "required": [
@@ -80960,7 +80975,12 @@
           "userListLimit",
           "userEachUserListsLimit",
           "rateLimitFactor",
-          "avatarDecorationLimit"
+          "avatarDecorationLimit",
+          "canImportAntennas",
+          "canImportBlocking",
+          "canImportFollowing",
+          "canImportMuting",
+          "canImportUserLists"
         ]
       },
       "ReversiGameLite": {

Get diff files from Workflow Page

Copy link
Collaborator

@KisaragiEffective KisaragiEffective left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

packages/frontend/src/pages/admin/roles.vue Show resolved Hide resolved
locales/index.d.ts Outdated Show resolved Hide resolved
@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review September 19, 2024 15:03
@kakkokari-gtyih
Copy link
Contributor Author

ちゃんと動いたのでready

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.9.0 milestone Sep 19, 2024
@syuilo
Copy link
Member

syuilo commented Sep 19, 2024

コンテンツごとに設定が分かれている必要はあるかしら

@KisaragiEffective
Copy link
Collaborator

目的を達成するためには別れてなくてもいいとは言えるが、別れていたほうが柔軟性を提供できて便利という説がある

@syuilo
Copy link
Member

syuilo commented Sep 19, 2024

あまり別々に設定したいシチュエーションが思い浮かばない

@KisaragiEffective
Copy link
Collaborator

  • フォローは悪用されると連合先に対してDRDoSになる
  • その他は悪用されるとローカルに対してDDoSになる

のでフォローとそれ以外にするのはありかもしれない

@syuilo
Copy link
Member

syuilo commented Sep 19, 2024

ほむん

@kakkokari-gtyih
Copy link
Contributor Author

分かれているぶんにはデメリットは無い気がする

@syuilo syuilo merged commit f0834ca into misskey-dev:develop Sep 20, 2024
32 of 33 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 20, 2024

👍🏿

@kakkokari-gtyih kakkokari-gtyih deleted the enh-14581 branch September 20, 2024 12:13
@syuilo
Copy link
Member

syuilo commented Sep 20, 2024

分かれているぶんにはデメリットは無い気がする

  • APIのペイロードが増加する
  • コード量が増える
  • 設定を行う際の手間が増える
  • テキストの翻訳コストが増える

kakkokari-gtyih added a commit to HanaMisskey/misskey that referenced this pull request Sep 25, 2024
* enhance: インポート操作の実行可否をロールで制御できるように

* Update Changelog

(cherry picked from commit f0834ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mastodonからの通報「フォローインポートをロール制に」に対応できない
3 participants