-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: ユーザーコンテンツのインポート操作の実行可否をロールで制御できるように #14583
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14583 +/- ##
===========================================
+ Coverage 39.77% 41.48% +1.71%
===========================================
Files 1539 1543 +4
Lines 191686 197603 +5917
Branches 2482 2607 +125
===========================================
+ Hits 76241 81984 +5743
- Misses 114883 115057 +174
Partials 562 562 ☔ View full report in Codecov by Sentry. |
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -80932,6 +80932,21 @@
},
"avatarDecorationLimit": {
"type": "integer"
+ },
+ "canImportAntennas": {
+ "type": "boolean"
+ },
+ "canImportBlocking": {
+ "type": "boolean"
+ },
+ "canImportFollowing": {
+ "type": "boolean"
+ },
+ "canImportMuting": {
+ "type": "boolean"
+ },
+ "canImportUserLists": {
+ "type": "boolean"
}
},
"required": [
@@ -80960,7 +80975,12 @@
"userListLimit",
"userEachUserListsLimit",
"rateLimitFactor",
- "avatarDecorationLimit"
+ "avatarDecorationLimit",
+ "canImportAntennas",
+ "canImportBlocking",
+ "canImportFollowing",
+ "canImportMuting",
+ "canImportUserLists"
]
},
"ReversiGameLite": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
ちゃんと動いたのでready |
コンテンツごとに設定が分かれている必要はあるかしら |
目的を達成するためには別れてなくてもいいとは言えるが、別れていたほうが柔軟性を提供できて便利という説がある |
あまり別々に設定したいシチュエーションが思い浮かばない |
のでフォローとそれ以外にするのはありかもしれない |
ほむん |
分かれているぶんにはデメリットは無い気がする |
👍🏿 |
|
* enhance: インポート操作の実行可否をロールで制御できるように * Update Changelog (cherry picked from commit f0834ca)
What
かいてあるとおり
Why
Fix #14581
Additional info (optional)
Checklist