Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ミュートしている人からのリアクション通知があると、通知があると表示される #5704

Closed
syuilo opened this issue Jan 10, 2020 · 3 comments · Fixed by #5712
Closed

ミュートしている人からのリアクション通知があると、通知があると表示される #5704

syuilo opened this issue Jan 10, 2020 · 3 comments · Fixed by #5712
Assignees
@syuilo
Labels
🧩API Issues regarding the interface between the server and the client. 🐛Bug Unexpected behavior packages/backend Server side specific issue/PR
Milestone
v12

Comments

@syuilo
Copy link
Member

syuilo commented Jan 10, 2020

💡 Summary

🙂 Expected Behavior

通知はないものとして扱われる

☹️ Actual Behavior

通知自体は見えないけど通知があると表示される

📝 Steps to Reproduce

📌 Environment
@syuilo syuilo added 🐛Bug Unexpected behavior 🧩API Issues regarding the interface between the server and the client. packages/backend Server side specific issue/PR ❓needs more investigation A bug whose causes are unknown labels Jan 10, 2020
@rinsuki
Copy link
Contributor

rinsuki commented Jan 11, 2020

このへん?
https://github.com/syuilo/misskey/blob/d09d06e4cb86ce90a391cbe96a59df633c809fd4/src/models/repositories/user.ts#L197-L203

@syuilo
Copy link
Member Author

syuilo commented Jan 11, 2020

そこでミュートしてるユーザーからの通知は無視するような処理してた気がしたけど気のせいだったか…
ありがとうございます👍

@syuilo syuilo removed the ❓needs more investigation A bug whose causes are unknown label Jan 11, 2020
@syuilo syuilo self-assigned this Jan 12, 2020
@syuilo syuilo added this to the v12 milestone Jan 28, 2020
@syuilo syuilo mentioned this issue Jan 28, 2020
Merged
@tamaina tamaina reopened this May 13, 2020
@tamaina tamaina closed this as completed May 13, 2020
@tamaina
Copy link
Contributor

tamaina commented May 13, 2020

GitHubのインデックスのバグによりRecloseします…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syuilo syuilo

Labels
🧩API Issues regarding the interface between the server and the client. 🐛Bug Unexpected behavior packages/backend Server side specific issue/PR
Projects
None yet
Milestone
v12
Development

Successfully merging a pull request may close this issue.

v12 misskey-dev/misskey
3 participants
@syuilo @rinsuki @tamaina