Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

全てのドメイン固有概念には固有の接頭辞を付けて表現する #11496

Closed
syuilo opened this issue Aug 9, 2023 · 1 comment · Fixed by #11719
Closed

全てのドメイン固有概念には固有の接頭辞を付けて表現する #11496

syuilo opened this issue Aug 9, 2023 · 1 comment · Fixed by #11719
Labels
packages/backend Server side specific issue/PR 💚Refactor Rewriting code without changing behavior

Comments

@syuilo
Copy link
Member

syuilo commented Aug 9, 2023

Summary

例えば「Event」という概念をMisskeyに実装したいとする
そのままコード内でEventとしてしまうと、プログラミングにおけるeventとの区別がつかないし環境によっては名前が衝突する

そこで全てのドメイン固有概念には固有の接頭辞を付けて表現する(MiUser、MiNote、MiEventなど)ようにすることでそういった問題を解決したい
@syuilo syuilo added packages/backend Server side specific issue/PR 💚Refactor Rewriting code without changing behavior labels Aug 9, 2023
@syuilo syuilo mentioned this issue Aug 9, 2023
Open
15 tasks
@syuilo
Copy link
Member Author

syuilo commented Aug 14, 2023

やるか

@syuilo syuilo mentioned this issue Aug 14, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
packages/backend Server side specific issue/PR 💚Refactor Rewriting code without changing behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: prefix Mi for all entities misskey-dev/misskey
1 participant
@syuilo