Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix direct fade not stopping running corutine #1645

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix direct fade not stopping running corutine #1645

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
777d883
Fix direct fade not stopping running corutine
Samdal Jul 29, 2022
3d4c67e
set task to None to prevent double cancel
Samdal Jul 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mpf/platforms/interfaces/light_platform_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ def set_fade(self, start_brightness, start_time, target_brightness, target_time)
self.task = self.loop.create_task(self._fade(start_brightness, start_time, target_brightness, target_time))
self.task.add_done_callback(Util.raise_exceptions)
else:
if self.task:
self.task.cancel()
Samdal marked this conversation as resolved.
Show resolved Hide resolved
self.set_brightness_and_fade(target_brightness, max(fade_ms, 0))

async def _fade(self, start_brightness, start_time, target_brightness, target_time):
Expand Down