Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony templating component required #203

Open
Nek- opened this issue Aug 1, 2019 · 2 comments
Open

Symfony templating component required #203

Nek- opened this issue Aug 1, 2019 · 2 comments

Comments

@Nek-
Copy link

Nek- commented Aug 1, 2019

The class PhoneNumberHelper which extends Symfony\Component\Templating\Helper\HelperInterface and is used in the context of a twig extension force the installation of symfony/templating.

Problem: Symfony templating is going to be deprecated (that's why the twig part does not require it anymore).

We should find a smooth solution to make work the bundle without the need of templating component. My first idea is to use a trait. WDYT ?
@OskarStark
Copy link

I have the same problem, requiring symfony/templating works but as you said... its deprecated

@Nek-
Copy link
Author

Nek- commented Aug 11, 2019 •
edited
Loading

@rh389 please tag it as help wanted if you accept my solution. cc @thewilkybarkid

@odolbeau odolbeau mentioned this issue Nov 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nek- @OskarStark