-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
idf.py
can't get Git revision to report version
#5
Comments
There is also a similar problem when building a project - cannot use |
I cannot build rust project because it complains about absence of git repository. And I think I cannot force it to skip the check.
|
I entered the shell through |
I cannot build the hello_world example. Has anyone managed to do that yet? The idf complains about Here's a full log:
|
I don't know if this is applicable to other build error, but I notices that |
I tried to reproduce this on manjaro, following the official install instructions, but there it seems to work fine in an empty git repo. |
I filed a bug against this upstream in esp-idf, it might be something that could make sense to fix there, even if we can get a workaround on this side. |
Mostly the Git errors don't actually seem to stop the build, but in your case CMake throws an error that might be what stops the build:
If I run the same commands you did on NixOS, I get a successful build, and that file My console output from successful build
Thank you all for your work and input on this! |
About my PR: On further inspection it seems like the esp-idf cmake scripts also check for a version.txt in other locations, I haven't had time to check the details, but if we're lucky it might make it so that the build process never tries to run Of course it doesn't matter as much now that the errors are ignored, but it would still be nice if we could make it not print "fatal" errors. ;) Here is an example of a location where it checks for version.txt (or actually, where |
Whoops, I didn't mean to close this. |
Running
idf.py --version
complains that Git can't get the version.Probably can be ultimately solved by using the
deepClone
option infetchFromGitHub
inpkgs/esp-idf/default.nix
(justleaveDotGit
doesn't work because no tags are present I think, Git "cannot describe anything") and making sure to copy the.git
directory to$out
, but that causes problems fetching/checking out the repository.This would change all the esp-idf hashes, so they have to be updated in:
pkgs/esp-idf/default.nix
examples/shell-override-versions.nix
Needs more investigation. We still do get a version number regardless at the moment.
The text was updated successfully, but these errors were encountered: