Fix isomorphism between of_seed/of_string and awa_gen_key #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
reviewed
Nov 25, 2021
hannesm
reviewed
Nov 25, 2021
|
Thanks for your PR. I just pushed a commit to your branch, what do you think about the result? :) it attempts to modify less code, and have the same observational behaviour (not removing the log messages). |
|
Good for me 👍. |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Dec 14, 2021
CHANGES: * use `eqaf` and hash to test the password (@dinosaure, @hannesm, mirage/awa-ssh#41) * fix isomorphism between `of_seed`/`of_string` and `awa_gen_key` tool (@dinosaure, @hannesm, mirage/awa-ssh#40) * provide `Keys.of_string` (@dinosaure, @hannesm, mirage/awa-ssh#37) * conflict `awa` with `result < 1.5` (@hannesm, 1c3d2eb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo this PR with
X509.Private_key.of_string(which requiresx509.0.15.2. This small patch brings an other type error in some way related to #36. However, we can merge it as is. I did not really test the isomorphism nor look deeper onX509.Private_key.of_string.