Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Session::reset throws an exception when main window has name #26

Closed
aik099 opened this issue Apr 6, 2024 · 4 comments · Fixed by #27
Closed

The Session::reset throws an exception when main window has name #26

aik099 opened this issue Apr 6, 2024 · 4 comments · Fixed by #27

Comments

@aik099
Copy link
Member

aik099 commented Apr 6, 2024

When the main window has a name and a couple of other windows are open, then the Session::reset call throws a NoSuchWindow exception, because it tries to determine the main window handle by its name after a popup window was just deleted while Selenium is in context of that deleted window (Web View).

Maybe for the internal window manipulations, the driver should use only window handles.

Related issue: #25

P.S.
I stumbled upon this error after fixing the #25 problem locally.

@stof
Copy link
Member

stof commented Apr 8, 2024

For internal usages, it would make sense to work directly with handles.

@aik099
Copy link
Member Author

aik099 commented Apr 8, 2024

For internal usages, it would make sense to work directly with handles.

Updated PR code to account for this.

@uuf6429
Copy link
Member

uuf6429 commented Apr 8, 2024

Maybe for the internal window manipulations, the driver should use only window handles.

Agreed, not sure why it wasn't like that already. We need to make sure that in old selenium we can also get some sort of window handle.

@aik099
Copy link
Member Author

aik099 commented Apr 9, 2024

... We need to make sure that in old selenium we can also get some sort of window handle.

@uuf6429 , Tested on Selenium 2 and everything works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants