-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up build by caching Selenium binary #238
Comments
https://docs.travis-ci.com/user/caching/#Things-not-to-cache |
Thanks, I know that. That's why I haven't proceeded with implementation, but still not sure if that JAR file is considered as large and how fast it's being downloaded from web compared to from cache. |
The download itself takes less than a second though. https://travis-ci.org/minkphp/MinkSelenium2Driver/jobs/169868663#L215 Caching vendor and installing with --prefer-dist should save ~14-17s. I'll submit PR to confirm. |
Downloading from the google CDN should not be slower than downloading from the Travis cache IMO (which lives either in AWS S3 or in the Google infrastructure). The 4s sleep should probably be removed. Starting xvfb is asynchronous but I'm quite sure we need it only when opening Firefox, i.e. when starting the first session. And we have other tasks running in between which should make it OK. |
Right now we download (via curl) fixed Selenium binary version. With Travis CI cache feature enabled we can download it to folder that will be cached and therefore avoid future downloads.
That should speed up the build.
The text was updated successfully, but these errors were encountered: