Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the changes in the git tag and/or the release on GitHub? #981

Closed
dorianmarie opened this issue Jan 12, 2024 · 10 comments
Closed

Have the changes in the git tag and/or the release on GitHub? #981

dorianmarie opened this issue Jan 12, 2024 · 10 comments

Comments

@dorianmarie
Copy link

What do you think?

I was trying to know what changed between 5.20.0 and 5.21.1

I think this will also get picked up by dependabot

@dorianmarie
Copy link
Author

@stefannibrasil
Copy link

Oh, thanks for the History link! Yeah, I was confused why dependabot PR did not contain any release notes. I remember it had at some point?

@zenspider
Copy link
Collaborator

zenspider commented Jan 15, 2024

If you go to tags and click on a version you're interested in, there is a compare dropdown that lets you pick another version and generates urls like so:

v5.20.0...v5.21.1

@zenspider
Copy link
Collaborator

zenspider commented Jan 15, 2024

https://rubygems.org/gems/minitest also has "Review Changes"

https://my.diffend.io/gems/minitest/5.20.0/5.21.1

@stefannibrasil
Copy link

Thanks, @zenspider ! I'm still not sure why, for example, dependabot used to pick up the changelog/commits in the version:

faker-ruby/faker#2804

but on the latest PR, it did not have any of the commit changes: faker-ruby/faker#2888

Maybe this is a bug on dependabot and not here? It's not a big deal, though, just trying to understand :)

@zenspider
Copy link
Collaborator

Dunno. Try filing a bug on it and see what they come up with.

@stefannibrasil
Copy link

That's usually what I do, I was just trying to confirm nothing had changed here before doing that ;) Thank you for your patience and for maintaining the gem 😊

@zenspider
Copy link
Collaborator

Please refer to this ticket there or link to that ticket here.

@dorianmarie
Copy link
Author

I think putting what's in History.rdoc into the git tags would help, it's much easier to review than reviewing source code diff

(In My Humble Opinion)

Closing this as that's not really a bug, more a For Your Information

@stefannibrasil
Copy link

Please refer to this ticket there or link to that ticket here.

Sorry, got busy with other things! I was about to do that when I noticed that dependabot opened a PR correctly this time:

faker-ruby/faker#2894 🤷‍♀️

I can see the version changes by clicking on the "compare view" link. I think this was just a glitch because all the other PRs have been opened with the details. I will keep an eye out if it happens again. If it does, I will open the bug report.

@minitest minitest locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants