PI-2676 Don't create a release if there is already an un-recalled release #4482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ease The integration service should never create a release where there is already an active release. Delius expects releases and recalls to be in order and alternating, so you would never have two releases in a row, unless there was a recall between them. Previously the `releaseDateValid` logic didn't account for an un-recalled release. If `custody.mostRecentRelease()` is not null, but `custody.mostRecentRelease().recall` _is_ null, then it returned `true` but it should have returned `false`.
achimber-moj
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration service should never create a release where there is already an active release. Delius expects releases and recalls to be in order and alternating, so you would never have two releases in a row, unless there was a recall between them.
Previously the
releaseDateValidlogic didn't account for an un-recalled release. Ifcustody.mostRecentRelease()is not null, butcustody.mostRecentRelease().recallis null, then it returnedtruebut it should have returnedfalse.