Pin trivy default to v0.57.1
#295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richgreen-moj
force-pushed
the
fix/pin-trivy-default
branch
from
f2ffee1 to
c70245a
Compare
ASTRobinson
approved these changes
Dec 11, 2024
connormaglynn
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
The default version of Trivy was set to
latestand recently we have been encountering errors like this..There seem to be a lot of changes in the latest release
v0.58.0with regards to how the Go function parses Terraform for Trivy (pkg/iac/scanners/terraform/parser/parser.go) so it could be a bug that's been introduced.Changes Made
Regardless of the potential bug in the latest release it seems a good idea to pin the version rather than using latest for stability.
I did try using commit hashes rather than release tags but it didn't play nicely.
The default trivy version has been pinned to
v0.57.1Tests
I've run this against the MP static analysis full scan job which was failing the error but works now... https://github.com/ministryofjustice/modernisation-platform/actions/runs/12275185943/job/34249712685