Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fmd 584 contact redesign #633

Merged
merged 13 commits into from
Aug 7, 2024
Merged

Fmd 584 contact redesign #633

merged 13 commits into from
Aug 7, 2024

Conversation

LavMatt
Copy link
Contributor

@LavMatt LavMatt commented Aug 6, 2024

PR updates the contacts partial template to the agreed improved contact design.

  • The contact partial template now applies some logic within the template to render the appropriate link/text dependent on the value in the access_requirements custom property:
    1. a sole link given is rendered as a hyperlink with standard link text
    2. some other specific free text held in the access_requirements custom property is
      shown as given
    3. where no access_requirements custom property exists default to the standard line
  • Amends some values in the new copy file and adds in new request access hyperlink text
  • Adds a new function is_access_requirements_a_url() to details service to indicate whether the access_requirements custom property value is a url.
  • Adds a new selenium test to make sure trhe logic is correctly rendered on the details page.
  • And a unit test for the is_access_requirements_a_url function (and another unit test for _parse_parent() that wasn't added before - my bad)
  • Also updated the tests workflow to compile messages as where these have changed they were not picked up by selenium tests

Kind of related as will populate the request access for all cadet models with a default but sensible link - i've done this PR but it has not been picked up https://github.com/moj-analytical-services/create-a-derived-table/pull/1883

Maybe Jake HP will have a look when he is back on 07/08 though

If you want to look at it either by deploying or running the branch locally - in the dev env i have added a test_pk table where i have put the link i've got in the above PR for the cadet request access default link

@LavMatt LavMatt marked this pull request as ready for review August 6, 2024 15:32
@LavMatt LavMatt requested a review from a team as a code owner August 6, 2024 15:32
home/service/details.py Outdated Show resolved Hide resolved
home/service/details.py Outdated Show resolved Hide resolved
MatMoore
MatMoore previously approved these changes Aug 6, 2024
@MatMoore MatMoore merged commit 718c57d into main Aug 7, 2024
7 checks passed
@MatMoore MatMoore deleted the fmd-584-contact-redesign branch August 7, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants