-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fmd 584 contact redesign #633
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LavMatt
force-pushed
the
fmd-584-contact-redesign
branch
from
August 6, 2024 14:34
50c3cd5
to
fb2eb7f
Compare
murdo-moj
reviewed
Aug 6, 2024
MatMoore
reviewed
Aug 6, 2024
MatMoore
reviewed
Aug 6, 2024
MatMoore
previously approved these changes
Aug 6, 2024
MatMoore
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR updates the contacts partial template to the agreed improved contact design.
access_requirements
custom property:shown as given
is_access_requirements_a_url()
to details service to indicate whether theaccess_requirements
custom property value is a url.is_access_requirements_a_url
function (and another unit test for_parse_parent()
that wasn't added before - my bad)Kind of related as will populate the request access for all cadet models with a default but sensible link - i've done this PR but it has not been picked up https://github.com/moj-analytical-services/create-a-derived-table/pull/1883
Maybe Jake HP will have a look when he is back on 07/08 though
If you want to look at it either by deploying or running the branch locally - in the dev env i have added a test_pk table where i have put the link i've got in the above PR for the cadet request access default link