Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align dev find-moj-data domains to current cadet domains #385

Closed
3 tasks
LavMatt opened this issue May 31, 2024 · 0 comments · Fixed by #407
Closed
3 tasks

Align dev find-moj-data domains to current cadet domains #385

LavMatt opened this issue May 31, 2024 · 0 comments · Fixed by #407
Assignees

Comments

@LavMatt
Copy link
Contributor

LavMatt commented May 31, 2024

User Story

As a developer
I expect the dev env domains to be aligned with our currently used domains
So that we can properly use dev for development

Proposal

Following completion of this issue #343 we should have entities assigned to domains as they're defined in create-a-derived-table.

Our dev env still has an old iteration of domains that we used during early development. We should align the code to use the current domains for all environments so tidy up the code in our domain model https://github.com/ministryofjustice/find-moj-data/blob/main/home/forms/domain_model.py#L19

Otherwise searches by domain will not return anything in the dev env

We want to dynamically pull the domains from datahub rather than reference a list of hardcoded domains within the find-moj-data app

Definition of Done

  • All environments use the same version of domains
  • dev filter by domain works as expected
  • fix hardcoded domains in findmojdata so that they align with cadet/datahub automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

2 participants