Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find-moj-data: search term highlight tags #114

Closed
jemnery opened this issue Feb 29, 2024 · 1 comment · Fixed by #169
Closed

find-moj-data: search term highlight tags #114

jemnery opened this issue Feb 29, 2024 · 1 comment · Fixed by #169
Assignees

Comments

@jemnery
Copy link
Contributor

jemnery commented Feb 29, 2024

Check this is true, but I think when we highlight search terms the correct accessible approach is to use <mark> tags

E.g. instead of

<p>Derived table that has one row per <strong>offence</strong> for all defendants across all cases</p>

Do this

<p>Derived table that has one row per <mark>offence</mark> for all defendants across all cases</p>

And then style the font-weight of mark.

Live example from our publications search here.

@jemnery jemnery converted this from a draft issue Feb 29, 2024
@mitchdawson1982 mitchdawson1982 self-assigned this Feb 29, 2024
@murdo-moj murdo-moj moved this to Todo in Data Catalogue Mar 1, 2024
@mitchdawson1982 mitchdawson1982 moved this from Todo to In Progress in Data Catalogue Mar 4, 2024
@mitchdawson1982 mitchdawson1982 moved this from In Progress to Todo in Data Catalogue Mar 4, 2024
@YvanMOJdigital YvanMOJdigital moved this from Todo to In Progress in Data Catalogue Mar 12, 2024
@mitchdawson1982
Copy link
Collaborator

mitchdawson1982 commented Mar 13, 2024

  • Awaiting PR review

@mitchdawson1982 mitchdawson1982 linked a pull request Mar 13, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Data Catalogue Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

2 participants