Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the ResultType enum and handle further entity types #40

Closed
3 tasks
LavMatt opened this issue Feb 20, 2024 · 1 comment
Closed
3 tasks

Expand the ResultType enum and handle further entity types #40

LavMatt opened this issue Feb 20, 2024 · 1 comment

Comments

@LavMatt
Copy link
Contributor

LavMatt commented Feb 20, 2024

User Story

As a catalogue
I expect to have my searches return the results of multiple types (e.g. dataset, chart, dashboard)
So that i am aware of all available representations of the data i'm searching for

Currently we only handle data products and datasets

Value / Purpose

https://github.com/ministryofjustice/data-platform/blob/main/python-libraries/data-platform-catalogue/data_platform_catalogue/client/datahub/search.py#L159 and https://github.com/ministryofjustice/data-platform/blob/main/python-libraries/data-platform-catalogue/data_platform_catalogue/client/datahub/search.py#L95 you can see how we don;t handle all entities. Will need to add more and suitable parsers for each new enitity

Useful Contacts

No response

User Types

No response

Hypothesis

If we... [do a thing]
Then... [this will happen]

Proposal

No response

Additional Information

Could do with some more discussion and agreement of what entities to focus on

Definition of Done

  • ResultType enum expanded
  • add those result types to all search client methods where appropriate, along with suitable parser{type} method
  • Update tests for more entity types
@MatMoore
Copy link
Contributor

This is out of date -

we are now handling data product, container, dataset, chart

@moj-data-platform-robot moj-data-platform-robot transferred this issue from ministryofjustice/analytical-platform Apr 25, 2024
@YvanMOJdigital YvanMOJdigital closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Data Catalogue Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

No branches or pull requests

4 participants