From effcf5571c2c97e22373242f61735d3cbbcde0a6 Mon Sep 17 00:00:00 2001 From: Antony Bishop <36888942+AntonyBishop@users.noreply.github.com> Date: Fri, 17 Jan 2025 13:00:58 +0000 Subject: [PATCH 1/3] Add YJAF AWS account access to modernisation_platform_engineering --- management-account/terraform/sso-admin-account-assignments.tf | 1 + 1 file changed, 1 insertion(+) diff --git a/management-account/terraform/sso-admin-account-assignments.tf b/management-account/terraform/sso-admin-account-assignments.tf index ea30949a..014a8fe6 100644 --- a/management-account/terraform/sso-admin-account-assignments.tf +++ b/management-account/terraform/sso-admin-account-assignments.tf @@ -260,6 +260,7 @@ locals { aws_organizations_account.modernisation_platform.id, aws_organizations_organization.default.master_account_id, aws_organizations_account.organisation_security.id + aws_organizations_account.youth_justice_framework_management.id ] }, { From df40e30ea2aeff543d95071bcc777e6e8d3fc34c Mon Sep 17 00:00:00 2001 From: Antony Bishop <36888942+AntonyBishop@users.noreply.github.com> Date: Fri, 17 Jan 2025 13:12:07 +0000 Subject: [PATCH 2/3] Add missing comma --- management-account/terraform/sso-admin-account-assignments.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/management-account/terraform/sso-admin-account-assignments.tf b/management-account/terraform/sso-admin-account-assignments.tf index 014a8fe6..c3826e9c 100644 --- a/management-account/terraform/sso-admin-account-assignments.tf +++ b/management-account/terraform/sso-admin-account-assignments.tf @@ -259,7 +259,7 @@ locals { account_ids = [ aws_organizations_account.modernisation_platform.id, aws_organizations_organization.default.master_account_id, - aws_organizations_account.organisation_security.id + aws_organizations_account.organisation_security.id, aws_organizations_account.youth_justice_framework_management.id ] }, From f5f087c49858a8faf4bc8b35b0915564d75fc945 Mon Sep 17 00:00:00 2001 From: Antony Bishop <36888942+AntonyBishop@users.noreply.github.com> Date: Fri, 17 Jan 2025 15:40:22 +0000 Subject: [PATCH 3/3] Add permission the the correct block --- .../terraform/sso-admin-account-assignments.tf | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/management-account/terraform/sso-admin-account-assignments.tf b/management-account/terraform/sso-admin-account-assignments.tf index c3826e9c..508e2273 100644 --- a/management-account/terraform/sso-admin-account-assignments.tf +++ b/management-account/terraform/sso-admin-account-assignments.tf @@ -259,15 +259,15 @@ locals { account_ids = [ aws_organizations_account.modernisation_platform.id, aws_organizations_organization.default.master_account_id, - aws_organizations_account.organisation_security.id, - aws_organizations_account.youth_justice_framework_management.id + aws_organizations_account.organisation_security.id ] }, { github_team = "modernisation-platform-engineers", permission_set_arn = aws_ssoadmin_permission_set.administrator_access.arn, account_ids = [ - aws_organizations_account.modernisation_platform.id + aws_organizations_account.modernisation_platform.id, + aws_organizations_account.youth_justice_framework_management.id ] }, {