Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/database opt in #1333

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Fix/database opt in #1333

merged 2 commits into from
Sep 5, 2024

Conversation

jamesstottmoj
Copy link
Contributor

@jamesstottmoj jamesstottmoj commented Aug 30, 2024 •
edited
Loading

📝 Summary

This PR fixes an issue that could be caused by trying to opt in the database more than once on a single user.

🔍 What should the reviewer concentrate on?

  • Feedback on specific parts of the code
  • Check side effects, if any

🧑‍💻 How should the reviewer test these changes?

  • Pull down branch
  • set DPR_DATABASE_NAME to jstott_aug_hybrid_db_rl in .env
  • Grant permissions on both databases
  • Check hybrid access mode in LakeFormation console under permissions
  • Revoke access to one database and check that database is still there in hybrid access mode
  • Revoke access to the other database and check there are no opt ins in hybrid access mode
  • Check you can query what you have access to in athena

📚 Documentation status

  • No changes to the documentation are required

@jamesstottmoj jamesstottmoj mentioned this pull request Sep 5, 2024
Merged
julialawrence
julialawrence approved these changes Sep 5, 2024
View reviewed changes
Copy link

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks the same as the UI code.

@jamesstottmoj jamesstottmoj merged commit 4c1bbd0 into main Sep 5, 2024
12 checks passed
@jamesstottmoj jamesstottmoj deleted the fix/database-opt-in branch September 5, 2024 11:46
@jamesstottmoj jamesstottmoj restored the fix/database-opt-in branch September 6, 2024 11:44
@jamesstottmoj jamesstottmoj deleted the fix/database-opt-in branch September 6, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julialawrence julialawrence julialawrence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesstottmoj @julialawrence