Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Airflow email notifications marked as probable spoofed sender #3892

Closed
jacobwoffenden opened this issue Mar 28, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools

Comments

@jacobwoffenden
Copy link
Member

Describe the bug.

Data Engineering have reported that email notifications from Airflow are being marked with:

[PROBABLE SPOOFED SENDER]

The from address is [email protected]

This has started happening after Operations Engineering started modifying @digital.justice.gov.uk's mail security (Slack thread) to align with NCSC standards.

To Reproduce

TBC

Expected Behaviour

Mail is delivered without issue or warning

Additional context

Using a scoped domain is probably the way forward, we don't need to use Justice Digital's root domain, instead we can use a service domain, e.g. @airflow.analytical-platform.service.justice.gov.uk or @airflow.data-engineering.service.justice.gov.uk, the former if Analytical Platform now own Airflow

@jacobwoffenden jacobwoffenden added bug Something isn't working data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools labels Mar 28, 2024
@jacobwoffenden jacobwoffenden moved this from 👀 TODO to 🚀 In Progress in Analytical Platform Apr 2, 2024
@jacobwoffenden
Copy link
Member Author

Engaged with Operations Engineering to add Amazon SES DKIM records to digital.justice.gov.uk domain (https://mojdt.slack.com/archives/C01BUKJSZD4/p1712051983138979)

@jacobwoffenden jacobwoffenden moved this from 🚀 In Progress to 🚫 Blocked in Analytical Platform Apr 2, 2024
@moj-data-platform-robot moj-data-platform-robot moved this from 🚫 Blocked to 🛂 In Review in Analytical Platform Apr 2, 2024
@jacobwoffenden
Copy link
Member Author

Operations Engineering have added the DKIM records. Domain is now showing as validated in Amazon SES.

Have asked a Data Engineering customer to test email function again.

@jacobwoffenden jacobwoffenden self-assigned this Apr 2, 2024
@jacobwoffenden jacobwoffenden changed the title 🐞 Airflow email notification marked as probable spoofed sender 🐞 Airflow email notifications marked as probable spoofed sender Apr 2, 2024
@jacobwoffenden
Copy link
Member Author

@github-project-automation github-project-automation bot moved this from 🛂 In Review to 🎉 Done in Analytical Platform Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools
Projects
Archived in project
Development

No branches or pull requests

1 participant