Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Fix linting in JML Report #3771

Closed
jacobwoffenden opened this issue Mar 18, 2024 · 1 comment
Closed

🐞 Fix linting in JML Report #3771

jacobwoffenden opened this issue Mar 18, 2024 · 1 comment
Labels
bug Something isn't working data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools

Comments

@jacobwoffenden
Copy link
Member

Describe the bug.

Super-Linter's suite of Python linting tools fail on https://github.com/ministryofjustice/analytical-platform-jml-report

To Reproduce

  1. Run Super-Linter

Expected Behaviour

All Python linters pass

Additional context

No response
@jacobwoffenden jacobwoffenden added bug Something isn't working data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools labels Mar 18, 2024
@github-actions github-actions bot mentioned this issue Apr 1, 2024
Closed
@AntFMoJ AntFMoJ moved this from 👀 TODO to 🚀 In Progress in Analytical Platform Apr 9, 2024
@AntFMoJ AntFMoJ moved this from 🚀 In Progress to 🛂 In Review in Analytical Platform Apr 10, 2024
@AntFMoJ AntFMoJ mentioned this issue Apr 10, 2024
Merged
@AntFMoJ
Copy link
Contributor

AntFMoJ commented Apr 10, 2024

This PR implements refactoring and code fixes to resolve issues with linting.

It has been noted that unit tests have not been created, an action will be taken to create a new ticket for adding this in.

@AntFMoJ AntFMoJ moved this from 🛂 In Review to 🎉 Done in Analytical Platform Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools
Projects
Analytical Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobwoffenden @AntFMoJ