Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 datahub client's upsert_table method is wiping data product metadata #3207

Closed
LavMatt opened this issue Feb 5, 2024 · 0 comments · Fixed by #3235
Closed

🐛 datahub client's upsert_table method is wiping data product metadata #3207

LavMatt opened this issue Feb 5, 2024 · 0 comments · Fixed by #3235
Assignees
Labels
bug Something isn't working

Comments

@LavMatt
Copy link
Contributor

LavMatt commented Feb 5, 2024

Describe the bug.

When using the upsert_table method to create a table within a data product, after a data product is created with all of its properties we then do another upsert on that data product, to associate datasets with it, without passing any of the data products metadata to it other than the assets that are associated with it, this line

We need to make sure either data_product_metadata that is passed to the upsert_table method or the existing data product metadata, are included in the DataProductPropertiesClass used for the aspect of the metadata_event

To Reproduce

  1. run the test here
  2. observe the given data product description does not appear.

Expected Behaviour

we run the test or any other ingestion of metadata and metadata for data products persist.

Additional context

No response

@LavMatt LavMatt added the bug Something isn't working label Feb 5, 2024
@LavMatt LavMatt self-assigned this Feb 5, 2024
@LavMatt LavMatt moved this to Todo in Data Catalogue Feb 5, 2024
@LavMatt LavMatt moved this from Todo to In Progress in Data Catalogue Feb 5, 2024
@LavMatt LavMatt moved this from In Progress to Review in Data Catalogue Feb 8, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Data Catalogue Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

2 participants