Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Allow Configuration of Ingress Annotations in Cloud Platform Apps #3150

Closed
3 of 4 tasks
Tracked by #1827
julialawrence opened this issue Feb 1, 2024 · 3 comments
Closed
3 of 4 tasks
Tracked by #1827
Assignees
Labels
data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools enhancement enhancing an existing feature 🧑‍💻 Apps & Tools BAU (Epic #1827)

Comments

@julialawrence
Copy link
Contributor

julialawrence commented Feb 1, 2024

User Story

As an engineer, I would like to reduce the operational burden of maintaining and debugging RShiny apps by allowing customers more freedom to configure their ingresses.

Value / Purpose

We have had a support request from an app owner that we suspect could be fixed by allowing them to add an annotation to their ingress definition but currently, the webapp-cp helm chart does not expose that as an option. Therefore, changes like that must be applied to all customers across the board. This is undesirable. Further, this is something that needs to be done by the team when this kind of configuration is better done by the app owners.

Useful Contacts

@julialawrence

User Types

App owners

Hypothesis

If we allow more granu;ar configuration it will reduce our support overhead.

Proposal

Amend webapp-cp helm chart to allow custom ingress annotations to be passed in values file.
Document the change

Additional Information

Arose out of this ticket: https://github.com/ministryofjustice/data-platform-support/issues/429

Definition of Done

  • Annotations made configurable
  • Documentation updated
  • Original requestor notified
  • Changes tested with sample app
@julialawrence julialawrence added the bug Something isn't working label Feb 1, 2024
@julialawrence julialawrence changed the title [gitmoji] <title> 🔧 Allow Configuration of Ingress Annotations in Cloud Platform Apps Feb 1, 2024
@Ed-Bajo Ed-Bajo closed this as completed Feb 1, 2024
@julialawrence
Copy link
Contributor Author

This isn't completed?

@julialawrence julialawrence reopened this Feb 14, 2024
@julialawrence julialawrence moved this to 🧐 To Do in Analytical Platform Feb 14, 2024
@michaeljcollinsuk michaeljcollinsuk added data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools and removed bug Something isn't working labels Feb 14, 2024
@jacobwoffenden jacobwoffenden self-assigned this Feb 19, 2024
@jacobwoffenden jacobwoffenden moved this from 👀 TODO to 🚀 In Progress in Analytical Platform Feb 19, 2024
@jacobwoffenden jacobwoffenden moved this from 🚀 In Progress to 🛂 In Review in Analytical Platform Feb 19, 2024
@jacobwoffenden
Copy link
Member

Feedback from support is that issue still occurs, however that is out of scope for this work and the required functionality has been delivered, therefore I will close this ticket.

@github-project-automation github-project-automation bot moved this from 🛂 In Review to 🎉 Done in Analytical Platform Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools enhancement enhancing an existing feature 🧑‍💻 Apps & Tools BAU (Epic #1827)
Projects
Archived in project
Development

No branches or pull requests

5 participants