Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Multiple Apps unexpected loss of service #1826

Closed
Tracked by #1827
Gary-H9 opened this issue Oct 9, 2023 · 5 comments
Closed
Tracked by #1827

🐛 Multiple Apps unexpected loss of service #1826

Gary-H9 opened this issue Oct 9, 2023 · 5 comments
Assignees
Labels
bug Something isn't working data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools 🧑‍💻 Apps & Tools BAU (Epic #1827)

Comments

@Gary-H9
Copy link
Contributor

Gary-H9 commented Oct 9, 2023

Describe the bug.

A number of users have reported unexpected loss of service / pod-restart.

To Reproduce

Hypothesis is that this occurs when auto-reconnections are fired many times.

Expected Behaviour

Apps should not spontaneously restart. Working hypothesis in this Slack thread.

Additional context

This is occurring on:

@Gary-H9 Gary-H9 added the bug Something isn't working label Oct 9, 2023
@Gary-H9 Gary-H9 added the data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools label Oct 9, 2023
@Gary-H9
Copy link
Contributor Author

Gary-H9 commented Oct 13, 2023

Captured Joe's app in the main body of the ticket.

@julialawrence julialawrence moved this from 🧐 To Do to 💨 In Progress in Analytical Platform Oct 23, 2023
@michaeljcollinsuk
Copy link
Contributor

michaeljcollinsuk commented Oct 24, 2023

The POC using open source shiny server was tested on gold-scorecard-form app from 19/10/23 to 23/10/23. This testing went well, we found the following:

  • websocket connection times are still inconsistent, but the reconnection behaviour is much improved
  • user remains in the same place when the reconnection occurred, the scorecard is not reloaded, and changes are not lost

App owner was happy with these changes, and deployed to the production environment on 24/10/23.

Our next step is to create a new base image that captures the amendments we made to the open-source server. We will then be able to test this image with the other apps mentioned in this ticket (pfg-dash-moj and https://github.com/ministryofjustice/data-platform-support/issues/265)

@michaeljcollinsuk
Copy link
Contributor

Opened PR's to deploy the new base image to the prison-network-app and pfg-dash-moj app:

https://github.com/ministryofjustice/prison-network-app/pull/129
https://github.com/ministryofjustice/pfg-dash-moj/pull/275

Currently awaiting feedback from the app owners

@michaeljcollinsuk michaeljcollinsuk moved this from 💨 In Progress to 👀 In Review in Analytical Platform Nov 2, 2023
@michaeljcollinsuk michaeljcollinsuk moved this from 👀 In Review to ✋ Blocked in Analytical Platform Nov 2, 2023
@Emterry Emterry moved this from ✋ Blocked to 👀 In Review in Analytical Platform Nov 3, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✨ Done ✨ in Analytical Platform Nov 9, 2023
@joeprinold
Copy link

@michaeljcollinsuk and @ymao2 a similar issue seems to be occurring on a couple of our other apps. Should I just go ahead and apply the fix to those apps or is that something that you'd want to review first?

@ymao2
Copy link
Contributor

ymao2 commented Nov 16, 2023

@joeprinold we have written the guide about how to migrate to use new open-source shiny server
https://user-guidance.analytical-platform.service.justice.gov.uk/apps/rshiny-app.html#open-source-shiny-server

so, Yes, you can go ahead to apply the fix, if you encounter any issue during the process, just raise a new support issue.

@jacobwoffenden jacobwoffenden moved this to 🎉 Done in Analytical Platform Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools 🧑‍💻 Apps & Tools BAU (Epic #1827)
Projects
Archived in project
Development

No branches or pull requests

5 participants