Bugfix/revoke permissions #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes are to ensure that if deleting the table access fails, the users original permissions are restored, and the database object remains. Otherwise the state of the DB and LF could get out of sync.
This change allows the revoke_permission method to silently fail if the permission does not exist. This is useful when revoking permissions that may have already been revoked, and avoids getting in a state where the user cannot be granted permissions again.
When creating users, use the UPN, preferred username or email address. This will only occur on initial login. For existing users, a data migration has been addeded to update the usernames to their email address, with the domain lowercase. This resolves a bug where permissions were not granted to the correct quicksight user ARN, as it was using the email value and the users quicksight username used the User Principal Name (UPN).
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ministryofjustice/analytical-platform#5391
Resolves ministryofjustice/analytical-platform#5392