Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Clean up #247

Merged
merged 20 commits into from
Aug 28, 2024
Merged

UI Clean up #247

merged 20 commits into from
Aug 28, 2024

Conversation

jamesstottmoj
Copy link
Contributor

@jamesstottmoj jamesstottmoj commented Aug 20, 2024 •
edited
Loading

This PR makes the following changes:

  • Adds a suite of unit tests
  • Removes Govuk-Frontend-Django and upgrades Django to 5.1
  • Uses a new base template rather than from the removed package
  • Fixes missing favicon and apple touch moj logos
  • Bumped several dependencies

@jamesstottmoj jamesstottmoj marked this pull request as ready for review August 20, 2024 16:30
@jamesstottmoj jamesstottmoj requested a review from a team as a code owner August 20, 2024 16:30
michaeljcollinsuk
michaeljcollinsuk requested changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comment in the base template, otherwise looks good, thanks for the tests!

templates/govuk-frontend.html Show resolved Hide resolved
@michaeljcollinsuk michaeljcollinsuk self-requested a review August 23, 2024 09:19
@jamesstottmoj jamesstottmoj merged commit d1b3484 into main Aug 28, 2024
21 checks passed
@jamesstottmoj jamesstottmoj deleted the feature/remove-govuk-frontend-django branch August 28, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljcollinsuk michaeljcollinsuk michaeljcollinsuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesstottmoj @michaeljcollinsuk