Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/refresh session #243

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Bugfix/refresh session #243

merged 2 commits into from
Aug 19, 2024

Conversation

michaeljcollinsuk
Copy link
Contributor

When users auth/ID token expires, we silently refresh their session. However there was a bug that meant that the user would always be redirected to the homepage when their session refreshed.

This fixes the bug, by storing a "next" url in the session when it expires, and redirecting the user there if it is present.

When session expires redirect the user to the page
that they were trying to get to.
@michaeljcollinsuk michaeljcollinsuk requested a review from a team as a code owner August 16, 2024 15:52
Copy link
Contributor

@Gary-H9 Gary-H9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeljcollinsuk michaeljcollinsuk merged commit d14c8fa into main Aug 19, 2024
19 checks passed
@michaeljcollinsuk michaeljcollinsuk deleted the bugfix/refresh-session branch August 19, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants