Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port names to container ports #2326

Closed
filipdutescu opened this issue Sep 25, 2024 · 2 comments · Fixed by #2347
Closed

Add port names to container ports #2326

filipdutescu opened this issue Sep 25, 2024 · 2 comments · Fixed by #2347
Assignees

Comments

@filipdutescu
Copy link

Is your feature request related to a problem? Please describe.
The Prometheus PodMetricsEndpoint spec has deprecated the targetPort field, which would be able to take an Integer. Since the minio/tenant chart does not set names to port 9000 (which is used for metrics), I cannot move away from the deprecated field.

Unfortunately, minio appears to be moving away from that field for good, so the easiest option might be my proposal below.

Describe the solution you'd like
Define a name for the port in question. It doesn't need to be customizable via Helm, it can be static, but I would really appreciate the option to reference it by name.

Describe alternatives you've considered
Provide a PodMonitor in the Helm chart, which takes care of all of the setup, but that might be too much in terms of maintenance burden. Leaving it here as an option though.

Additional context

@jiuker
Copy link
Contributor

jiuker commented Oct 18, 2024

9000 is not just for metric

@filipdutescu
Copy link
Author

That is fine, it doesn't need to be. I just want to be able to reference it by name, i.e. http-port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants