[Bug] Property 'setRequestOptions' does not exist on type 'Client'

[b0939261761]

Hi,
node.js - 20.1.
minio - 7.1.1
typescript - 4.9.5

When I updated minio from version 7.0.32 to version 7.1.1, I got an error.

 error TS2339: Property 'setRequestOptions' does not exist on type 'Client'.

this.client.setRequestOptions({ rejectUnauthorized: false });

In the file minio.d.c there is no signature of the function setRequestOptions(options: RequestOptions): void;.

The @types/minio package has this signature of the function setRequestOptions
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/73fd4e988115d6a2d5fbf14343c8a28985eab4ad/types/minio/index.d.ts#L651

Thanks.

[trim21]

already fixed in master branch

[b0939261761]

Hi, In the master branch, I did not find the signature of the setRequestOptions function.

https://github.com/minio/minio-js/blob/master/src/minio.d.ts

[trim21]

Hi, In the master branch, I did not find the signature of the setRequestOptions function.

https://github.com/minio/minio-js/blob/master/src/minio.d.ts

Yes, now it's written in typescript so we don't need it in d.ts anymore

minio-js/src/internal/client.ts

Line 250 in 23ad6e2

public setRequestOptions(options: Pick<https.RequestOptions, (typeof requestOptionProperties)[number]>) {

[trim21]

you may still need types/minio before next version is released…

[prakashsvmx]

The 7.1.1 is to ensure the workflow is tested end to end. so you could wait for the upcoming releases. @b0939261761

[b0939261761]

I updated minio to version 7.1.1. The error remains "Property 'setRequestOptions' does not exist on type 'Client'."

[trim21]

yes, fixes is not released.