-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript typings wrong for copyObject operation #1097
Comments
There are many issues with the typings. Another is the It also requires the access and secret key for the client, which are actually optional. I'm sure there are other issues. |
@phal0r Since we've migrated Lines 404 to 416 in 23ad6e2
and confirm whether that is correct? p.s. me and @trim21 are not minio employee |
it's still wrong ( or maybe "incomplete" ), I didn't fixed this when importing minio.d.ts. missing overloads: copyObject(
bucketName: string,
objectName: string,
sourceObject: string,
callback: ResultCallback<BucketItemCopy>,
): void
copyObject(
bucketName: string,
objectName: string,
sourceObject: string,
conditions?: CopyConditions,
): Promise<BucketItemCopy> (we realy should consider dropping callback API) |
Given the latest releases:
Typings are wrong for copyObject. The overloads for optional CopyConditions are missing. Passing null also leads to the error, although optional CopyConditions or passing null is allowed and supported in the source.
The text was updated successfully, but these errors were encountered: