Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autogen.sh failing with KeyError: 'programming' #146

Closed
maruina opened this issue May 17, 2020 · 2 comments
Closed

autogen.sh failing with KeyError: 'programming' #146

maruina opened this issue May 17, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@maruina
Copy link
Contributor

maruina commented May 17, 2020

Hello, thanks for the awesome tool!
I'm trying to open a PR to add some gitops icons, but I can't get autogen.sh to work

❯ ./autogen.sh
converting the svg to png using inkscape for provider 'onprem'
cleaning the resource names for provider 'onprem'
cleaning the resource names for provider 'aws'
rounding the resources for provider 'aws'
converting the svg to png using inkscape for provider 'azure'
cleaning the resource names for provider 'azure'
cleaning the resource names for provider 'gcp'
cleaning the resource names for provider 'k8s'
cleaning the resource names for provider 'alibabacloud'
converting the svg to png using image magick for provider 'oci'
cleaning the resource names for provider 'oci'
cleaning the resource names for provider 'programming'
Traceback (most recent call last):
  File "/Users/ruio/.pyenv/versions/3.8.2/lib/python3.8/runpy.py", line 193, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/Users/ruio/.pyenv/versions/3.8.2/lib/python3.8/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/Users/ruio/github/third-party/diagrams/scripts/resource.py", line 168, in <module>
    commands[cmd](pvd)
  File "/Users/ruio/github/third-party/diagrams/scripts/resource.py", line 105, in clean_png
    [_rename(root, png) for png in pngs]
  File "/Users/ruio/github/third-party/diagrams/scripts/resource.py", line 105, in <listcomp>
    [_rename(root, png) for png in pngs]
  File "/Users/ruio/github/third-party/diagrams/scripts/resource.py", line 98, in _rename
    new = cleaners[pvd](png)
KeyError: 'programming'

I just forked the repo

❯ git l
* c046b8a (HEAD -> gitops, origin/master, origin/HEAD, master) generate tableau and metabase nodes (#142)
* 5c747f6 Added Github Star badge instead of dummy badge and github link (#144)
* cf0141a Add programming languages and frameworks (#112)
* 6a778fd Add: Loki to onprem.logging (#139)
* 248ad69 Added news icons to aws network resource (#135)
* b446cb5 Rename Cloudfront to CloudFront (#129)
* 353e7eb (tag: v0.10.0) bump: up to version 0.10.0
[...]

and I only added my 2 new icons

❯ git status
On branch gitops
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	resources/onprem/gitops/flagger.png
	resources/onprem/gitops/flux.png

nothing added to commit but untracked files present (use "git add" to track)

I follow the CONTRIBUTING guide but I don't understand if I'm missing a dependency or if it's something else.

@mingrammer
Copy link
Owner

Sorry for the inconvenience. Try with the latest commit, please. (just git pull)

@mingrammer mingrammer added the bug Something isn't working label May 17, 2020
@maruina
Copy link
Contributor Author

maruina commented May 17, 2020

It works now, thanks. I was able to raise #147

@maruina maruina closed this as completed May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants