Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerated files are using C++17 features, but this repository uses C++14 #47

Open
Morxemplum opened this issue Nov 29, 2024 · 1 comment

Comments

@Morxemplum
Copy link

When trying to compile mcpelauncher-ui upstream, this submodule is compiled as part of the process.

However, when I try to compile. I run into several errors with a particular autogenerated file called mocs_compilation.cpp. The common thread here is that it doesn't know what string_view is. string_view requires at minimum C++17. However, when looking at CMakeLists, it is setting the version to C++14. This repository is using an outdated C++ standard and will not compile.

set(CMAKE_CXX_STANDARD 14)

When setting this value to 17, the project compiles without these errors.

@Morxemplum
Copy link
Author

I can confirm this issue only happens when you are specifically compiling the Qt5 launcher. The Qt6 Launcher does not have this problem.

Considering that the project seems to be heading in a direction where Qt5 will be discontinued, I will close this issue once Qt5 is no longer the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant