Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress for adding 1.19.50 support #719

Closed
2 tasks done
ChristopherHX opened this issue Oct 13, 2022 · 2 comments · Fixed by #744
Closed
2 tasks done

Progress for adding 1.19.50 support #719

ChristopherHX opened this issue Oct 13, 2022 · 2 comments · Fixed by #744
Labels
enhancement New feature or request

Comments

@ChristopherHX
Copy link
Member

ChristopherHX commented Oct 13, 2022

  • fmod update, need to load a newer fmod version to provide the requested symbols.
    Probably not easy to do version detection, when a new fmod is needed. Workaround run with flag -df, you may need pulseaudio during compiling the launcher to have sound.
    New Reference _ZN4FMOD14ChannelControl19get3DMinMaxDistanceEPfS1_
  • lstat needs to be added to libc-shim
    New reference lstat from libc++_shared.so and more, contributed by @0xCatPKG 2022-10-22

Planned for 2023.

@GameParrot
Copy link
Contributor

GameParrot commented Dec 27, 2022

Manually adding the symbols to the fmod symbols file results in the game opening with sound (with the bundled fmod). However, the game freezes on exit unless --disable-fmod is passed (passing --disable-fmod results in no sound for me). Maybe an option to choose the fmod library path could be added to mcpelauncher-client and the launcher UI (mcpelauncher-ui-qt) could set the path depending on the version launched. I am using Linux Mint 21.
Edit: I was able to build with PulseAudio and get sound without --disable-fmod (causes the freeze on exit when using PulseAudio)

@ChristopherHX
Copy link
Member Author

@GameParrot Thank you for experimenting, the missing fmod symbol is indeed in the current mcpelauncher-linux-bin of fmod so no update is necessary.

I added all missing fmod symbols from a readelf dump to the list minecraft-linux/minecraft-imported-symbols@05168fb

I will close this once this has been merged into this meta repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants