Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Held Keybinds: Enter Key Releases Automatically #679

Open
Offroaders123 opened this issue Apr 9, 2022 · 3 comments
Open

Held Keybinds: Enter Key Releases Automatically #679

Offroaders123 opened this issue Apr 9, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Offroaders123
Copy link

Describe the bug
When setting a "held keybind" to be activated by the Enter/Return key, the action is released after a short period of time. A few examples of some "held keybind" actions include the Move Forwards, Move Left, and Sneak/Fly Down options.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Settings', either on the Start menu or while in gameplay through the Pause menu.
  2. Click on the 'Keyboard & Mouse' settings tab.
  3. Scroll down to the 'Sneak/Fly Down' keybind. Click on the keybind option that lists the current keybind, then press your 'Enter/Return' key to set the keybind to use 'Enter/Return'.
  4. Go (back) into a world, and hold down your 'Enter/Return' key to activate 'Sneak' or 'Fly Down'. Notice that after about a half-second or so, 'Sneak/Fly Down' will be released even though you are still holding down the 'Enter/Return' key.

Expected behavior
Holding down the 'Enter/Return' key should not release after a short period of time.

Screenshots
Sneak/Fly Down Keybind Section

Desktop

  • OS: macOS
  • Version: v0.3.4-macOS-x86_64-0.2.361 (build 361)
  • Installation Type: dmg

Additional context
I first stumbled across this issue while playing on macOS. I later hopped over to Linux and native Bedrock on Windows to check if it was present on those platforms as well, and it wasn't. It appears to be something related to macOS specifically.

@Offroaders123 Offroaders123 added the bug Something isn't working label Apr 9, 2022
@ChristopherHX
Copy link
Member

Seems to be specfic to the glfw window provider of this launcher on both linux and macOS.

@Offroaders123
Copy link
Author

Is there a possible way to fix it? I can try to add a patch too if it's hard to find where it's at.

@ChristopherHX
Copy link
Member

ChristopherHX commented Apr 25, 2022

Is there a possible way to fix it?

Very likely, because the linux eglut window provider doesn't have this bug.

The bug must be somewhere in this file ( or in the glfw library )
https://github.com/minecraft-linux/game-window/blob/master/src/window_glfw.cpp

If you clone this github project recursively you already have a checkout of game-window.

I'm the only semi active contributor, contributions are welcome. I'm focusing on other projects

Edit:
In eglut you cannot type chars by holding a button, while it works in glfw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants