Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook data source validation into rule types API #5049

Closed
JAORMX opened this issue Nov 25, 2024 · 2 comments · Fixed by #5068 or #5111
Closed

Hook data source validation into rule types API #5049

JAORMX opened this issue Nov 25, 2024 · 2 comments · Fixed by #5068 or #5111
Assignees

Comments

@JAORMX
Copy link
Contributor

JAORMX commented Nov 25, 2024

The idea is that when a rule type is created or updated, we should always validate that the appropriate data soruces are available and valid.

We should also populate the rule_type_data_sources table with all of the rule type / data source relationships that are found, if all validations pass.

@JAORMX
Copy link
Contributor Author

JAORMX commented Nov 25, 2024

Please add your planning poker estimate with Zenhub @teodor-yanev

blkt added a commit that referenced this issue Nov 27, 2024
Rules can now specify a list of data sources names that they need for
their evaluation. This change ensures that data sources required by
the rule are available when creating the rule.

A similar change is being added in the code path implementing data
source deletion ensuring that a data source is not deleted if there
exist rules depending on it.

Fixes #5049
blkt added a commit that referenced this issue Nov 28, 2024
Rules can now specify a list of data sources names that they need for
their evaluation. This change ensures that data sources required by
the rule are available when creating the rule.

A similar change is being added in the code path implementing data
source deletion ensuring that a data source is not deleted if there
exist rules depending on it.

Fixes #5049
blkt added a commit that referenced this issue Nov 28, 2024
Rules can now specify a list of data sources names that they need for
their evaluation. This change ensures that data sources required by
the rule are available when creating the rule.

A similar change is being added in the code path implementing data
source deletion ensuring that a data source is not deleted if there
exist rules depending on it.

Fixes #5049
blkt added a commit that referenced this issue Nov 28, 2024
Rules can now specify a list of data sources names that they need for
their evaluation. This change ensures that data sources required by
the rule are available when creating the rule.

A similar change is being added in the code path implementing data
source deletion ensuring that a data source is not deleted if there
exist rules depending on it.

Fixes #5049
blkt added a commit that referenced this issue Nov 28, 2024
Rules can now specify a list of data sources names that they need for
their evaluation. This change ensures that data sources required by
the rule are available when creating the rule.

A similar change is being added in the code path implementing data
source deletion ensuring that a data source is not deleted if there
exist rules depending on it.

Fixes #5049
@JAORMX JAORMX reopened this Nov 28, 2024
@JAORMX
Copy link
Contributor Author

JAORMX commented Nov 28, 2024

this part still needs to happen "We should also populate the rule_type_data_sources table with all of the rule type / data source relationships that are found, if all validations pass."

blkt added a commit that referenced this issue Dec 2, 2024
This change adds code for the maintenance of references to Data
Sources during the creation or update of rule types.

To keep things simple and limit the amount of added code, the code
path is the same for both create and update, in that it always try to
delete references to data sources even in the case of rule creation,
which is always a noop.

Fixes #5049
blkt added a commit that referenced this issue Dec 2, 2024
This change adds code for the maintenance of references to Data
Sources during the creation or update of rule types.

To keep things simple and limit the amount of added code, the code
path is the same for both create and update, in that it always try to
delete references to data sources even in the case of rule creation,
which is always a noop.

Fixes #5049
blkt added a commit that referenced this issue Dec 2, 2024
This change adds code for the maintenance of references to Data
Sources during the creation or update of rule types.

To keep things simple and limit the amount of added code, the code
path is the same for both create and update, in that it always try to
delete references to data sources even in the case of rule creation,
which is always a noop.

Fixes #5049
@JAORMX JAORMX closed this as completed in c7e8d6d Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants