Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early Deletion of .git repo #80

Closed
MafcoCinco opened this issue Jan 4, 2013 · 2 comments
Closed

Early Deletion of .git repo #80

MafcoCinco opened this issue Jan 4, 2013 · 2 comments

Comments

@MafcoCinco
Copy link

I apologize if this is user error, but I am unable to get mina to deploy gems as the shell script generated by git.rb deletes the .git directory before executing the user defined portions of the deploy task. This is a problem as our .gemspec files use git ls-files to fill in the file list for the Gemspec DSL.

When rake build or gem build foo.gemspec is invoked in the deploy task, an error is thrown as the .git directory no longer exists. For rails, deleting the .git directory is probably not a big deal, but it makes things very difficult when deploying stand alone gems that are built on the remote server and pushed to a local instance of Gem-in-a-box.

Would anyone be opposed to moving the rm -rf .git command out of git.rb and into data/deploy.sh.erb. A good place might be right after the bootstrap section.

Again, if there is something I'm missing here and anyone can suggest a way to accomplish what I want (i.e. building gems on the remote server while still having git ls-files populating the file list in the .gemspec) I will happily use your suggestion. However, from what I have attempted so far this seems to be an issue in mina related to the fact that the .git directory is deleted prior to executing the user defined portion of the deploy task.

Thanks.

@larrylv
Copy link

larrylv commented Jan 15, 2014

+1 for this issue.

@d4be4st
Copy link
Member

d4be4st commented Jul 5, 2015

this might be a good mina-gem that you can include which would overwrite the deauft git tasks.
We want this to stay in mina as is

@d4be4st d4be4st closed this as completed Jul 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants