Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement transaction pool #21

Closed
ignopeverell opened this issue Dec 23, 2016 · 3 comments
Closed

Implement transaction pool #21

ignopeverell opened this issue Dec 23, 2016 · 3 comments

Comments

@ignopeverell
Copy link
Contributor

Keep transactions received from the network. Should occupy only a fixed amount of memory and evict based on time/fees. Eviction should also evict dependent transactions.

@MoaningMyrtle
Copy link
Contributor

Hey there,

Looking to take a crack at this.

Are you pretty happy with the Network/Chain adapter setup in adapters.rs? I was planning on largely duplicating that effort for pool connectivity.

Other than what's in your original post, any potential issues/ implementation thoughts you had?

@ignopeverell
Copy link
Contributor Author

Sorry, only seeing your comment now.

The higher level adapter approach is working fairly well so far in keeping those components somewhat independent. It's a little early to say if it's a good long term approach but it doesn't seem to create too many problems.

As far as potential issues, the pool needs to be able to iterate easily on all transactions for mining (using some priority selection algorithm) and needs to do some memory accounting for eviction. That's probably the 2 biggest constraints. So I'd design around these first.

@ignopeverell
Copy link
Contributor Author

Provided by #48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants